chore: fix ConstantFolding rule exclusion for benchmarks#4689
Merged
Conversation
comphead
changed the title
ConstantFolding rule exclusionConstantFolding rule exclusion for benchmarks
andygrove
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4656 .
Rationale for this change
Three Comet benchmark files set
spark.sql.optimizer.constantFolding.enabled = false, but this Spark config does not exist - it is silently ignored, so constant folding has been running during these benchmarks the whole time.Spark has no per-rule on/off flag for
ConstantFolding. The canonical way to disable an individual Catalyst rulespark.sql.optimizer.excludedRules, which takes a comma-separated list of fully-qualified rule class names (seeSQLConf.OPTIMIZER_EXCLUDED_RULES). The rest of the Comet test suite (CometExpressionSuite,CometStringExpressionSuite,CometArrayExpressionSuite,CometSqlFileTestSuite, etc.) already uses this pattern.What changes are included in this PR?
How are these changes tested?